Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance dubbo-cp #1219

Closed
wants to merge 6 commits into from
Closed

enhance dubbo-cp #1219

wants to merge 6 commits into from

Conversation

sjmshsh
Copy link

@sjmshsh sjmshsh commented Aug 16, 2023

add testClient, fix log, add name/namespace key during dds.

@codecov-commenter
Copy link

Codecov Report

Merging #1219 (865bb1a) into refactor-with-go-components-experimental (8562ead) will increase coverage by 0.18%.
The diff coverage is 59.47%.

@@                             Coverage Diff                              @@
##           refactor-with-go-components-experimental    #1219      +/-   ##
============================================================================
+ Coverage                                     46.68%   46.86%   +0.18%     
============================================================================
  Files                                           113      113              
  Lines                                          6439     6469      +30     
  Branches                                         41       41              
============================================================================
+ Hits                                           3006     3032      +26     
- Misses                                         3142     3145       +3     
- Partials                                        291      292       +1     
Files Changed Coverage Δ
pkg/core/cert/provider/client.go 0.00% <0.00%> (ø)
pkg/core/model/model.go 25.80% <ø> (ø)
pkg/core/tools/endpoint/endpoint.go 91.11% <ø> (ø)
pkg/core/cert/provider/storage.go 59.63% <16.66%> (ø)
pkg/dds/kube/crdclient/handler.go 53.62% <23.52%> (-4.59%) ⬇️
pkg/authority/server/authority.go 50.00% <25.00%> (ø)
pkg/core/cert/provider/util.go 75.82% <46.15%> (ø)
pkg/dds/kube/crdclient/client.go 75.78% <70.00%> (ø)
pkg/dds/storage/storage.go 94.07% <93.33%> (-0.60%) ⬇️
pkg/dds/storage/generate.go 89.56% <100.00%> (+6.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sjmshsh sjmshsh changed the title add testClient, fix log, fix dds enhance dubbo-cp Aug 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sjmshsh sjmshsh closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants